-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify_subject_alt_name testing to integration tests #725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is an awesome test addition. One tiny nit and one doc ask.
@@ -1,17 +1,17 @@ | |||
#include "common/ssl/connection_impl.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can you put newline between "related file" and the other headers. Same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
AD/GeVdxA5uNOX1x8DSo1GrdhxEqDEWpmGms0jFoRStgO2PsWNhBoXo/3yPWmsam | ||
GovtzLF4WapdtSTdn7ku91rx0BplNGOs0uuipnEtRoC7Eo31xaay4LppWTwtVZBA | ||
LaRR1p0mlCtvqI9dz25Uhl1UlXdvq+lHLxkAFp49CLYf | ||
MIICmjCCAgOgAwIBAgIJALd7PpOmDaMoMA0GCSqGSIb3DQEBCwUAMIGIMQswCQYD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of embarrassing, but at this point I honestly have no clue what the process is for getting this file updated and checked in. Since you clearly know substantially more about TLS than I do, can you possible add a small README.md to this directory explaining how all of this stuff gets generated and the process for updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* Revert "Strip out "spiffe://" in the identity (envoyproxy#719)" This reverts commit 99a482f. * Revert "Revert "Remove -release in filename when doing release build of proxy (envoyproxy#704)" (envoyproxy#723)" This reverts commit 13669ce. * Revert "Not to send legacy quota for v2 config. (envoyproxy#722)" This reverts commit aaf25ca.
)" (envoyproxy#733) This reverts commit ef74122.
No description provided.